Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache graphql query in query plan. #3106

Merged
merged 40 commits into from
Dec 13, 2024
Merged

feat: cache graphql query in query plan. #3106

merged 40 commits into from
Dec 13, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Nov 13, 2024 •
edited
Loading

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #3088

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Nov 13, 2024
@laststylebender14
- store selection at graphql IO level.
11b7733
@laststylebender14
- revert: selection from IO.
aa521de
@laststylebender14
- store selection in request_template while generating the plan.
a775b68
@laststylebender14
- fix indentation
e502f3e
@laststylebender14
- filter out args that has values.
2171fd7
@laststylebender14
- skip IR fields.
4ce9e4e
@laststylebender14
impl JsonLike for Value.
d66a424
@laststylebender14
- add support for directives.
cea0573
@laststylebender14
- impl to_string_value for JsonLike
64e3dc2
@laststylebender14
- we can apply GraphQL transformation only when selection set is enri…
fee9ea2 
…ched with variables.
@laststylebender14
- add transformation to plan.
ccb918a
@laststylebender14
- refactor: const_directive_to_sdl
44ddda1
@laststylebender14
- there's no point re-creating selection set during each request.
96df89e
@laststylebender14
- impl pathstring for Variables
186ab9f
@laststylebender14
- compute the variables at runtime query with mustache
f8734dd
@laststylebender14
- show query in info logger
8327582
@laststylebender14
- handle modify directive scenario
91db9ef
@laststylebender14
- lint changes
0b092e3
@laststylebender14
- clean up of transform
3cd304c
@laststylebender14
- minor clean up
eae3162
@laststylebender14
- make pos inline
c12de8b
@laststylebender14
- clean up the selection API.
8bcd4df
@laststylebender14
- rename func
57ee895
@laststylebender14
- lint changes
afd8ce4
@laststylebender14
- refactor: remove duplicate code.
d70ddf7
@laststylebender14
- revert: change in eval context.
ab5ef48
@laststylebender14
- use to_string method instead
600a769
@github-actions GitHub Actions
Copy link

🐰 Bencher Report

Branch3106/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD		6,180,100.00
group_by📈 view plot
⚠️ NO THRESHOLD		486.83
input/args.missing📈 view plot
⚠️ NO THRESHOLD		22.24
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD		42.29
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD		36.66
input/args.root📈 view plot
⚠️ NO THRESHOLD		38.13
input/headers.existing📈 view plot
⚠️ NO THRESHOLD		30.64
input/headers.missing📈 view plot
⚠️ NO THRESHOLD		29.77
input/value.missing📈 view plot
⚠️ NO THRESHOLD		22.22
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD		42.76
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD		35.13
input/value.root📈 view plot
⚠️ NO THRESHOLD		36.33
input/vars.existing📈 view plot
⚠️ NO THRESHOLD		8.16
input/vars.missing📈 view plot
⚠️ NO THRESHOLD		10.48
synth_nested📈 view plot
⚠️ NO THRESHOLD		95,324.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD		41,129.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD		1,877.40
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD		1,512,000.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD		395,490.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD		128,440.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD		62,087.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD		15,841.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD		1,134.10
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD		702.27
🐰 View full continuous benchmarking report in Bencher

@laststylebender14 laststylebender14 changed the title fix: send operation selection set to graphql upstream. feat: cache graphql query in query plan. Nov 18, 2024
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Nov 18, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Nov 18, 2024
@laststylebender14 laststylebender14 marked this pull request as draft November 20, 2024 16:08
@laststylebender14 laststylebender14 marked this pull request as ready for review November 25, 2024 11:18
@tusharmath
Copy link
Contributor

@MedHeikelBouzayene Can you try this PR and see if it resolves your use case reported in #3088

@tusharmath tusharmath marked this pull request as draft November 28, 2024 19:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Dec 3, 2024
@laststylebender14 laststylebender14 mentioned this pull request Dec 9, 2024
Closed
2 tasks
@MedHeikelBouzayene
Copy link
Contributor

@tusharmath @laststylebender14 yes it works fine for me, thank you

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Dec 13, 2024
@tusharmath tusharmath marked this pull request as ready for review December 13, 2024 20:03
@tusharmath tusharmath enabled auto-merge (squash) December 13, 2024 20:03
@tusharmath tusharmath merged commit 316254c into main Dec 13, 2024
28 of 30 checks passed
@tusharmath tusharmath deleted the fix/render-selection-set-directly branch December 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in the nested queries when working with @graphql
3 participants
@laststylebender14 @tusharmath @MedHeikelBouzayene